consider any touched input as not _unused_ (#3237)

* consider any touched input as not _unused_ * give event_test assert_receive more time
phoenixframework · May 10, 2024 · da4ba6b · da4ba6b
1 parent 4643fc1
commit da4ba6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/assets/js/phoenix_live_view/view.js b/assets/js/phoenix_live_view/view.js
@@ -102,8 +102,8 @@ let serializeForm = (form, metadata, onlyNames = []) => {
   let elements = Array.from(form.elements)
   for(let [key, val] of formData.entries()){
     if(onlyNames.length === 0 || onlyNames.indexOf(key) >= 0){
-      let input = elements.find(input => input.name === key)
-      let isUnused = !(DOM.private(input, PHX_HAS_FOCUSED) || DOM.private(input, PHX_HAS_SUBMITTED))
+      let inputs = elements.filter(input => input.name === key)
+      let isUnused = !inputs.some(input => (DOM.private(input, PHX_HAS_FOCUSED) || DOM.private(input, PHX_HAS_SUBMITTED)))
       if(isUnused && !(submitter && submitter.name == key)){
         params.append(prependFormDataKey(key, "_unused_"), "")
       }

diff --git a/test/phoenix_live_view/integrations/event_test.exs b/test/phoenix_live_view/integrations/event_test.exs
@@ -128,7 +128,7 @@ defmodule Phoenix.LiveView.EventTest do
                   end}
                )
 
-               assert_receive {:DOWN, _ref, :process, ^pid, _reason}
+               assert_receive {:DOWN, _ref, :process, ^pid, _reason}, 500
              end) =~ "Got: {:reply, :boom"
     end