Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: AzureOpenAI compatibility #74

Merged
merged 2 commits into from May 13, 2024

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented May 10, 2024

Azure requires

  1. Passing the API Key via a header api-key
  2. Passing the api-version as a query parameter

I know this is a breaking change, so I just put this here for discussion. @philippgille

@philippgille
Copy link
Owner

WDYT about adding a non-exported function that takes and handles these two additional parameters, and then both the NewEmbeddingFuncOpenAICompat and the NewEmbeddingFuncAzureOpenAI call that one, while the former stays backward-compatible and its param list is sufficient and simpler for most OpenAI-compatible APIs?

@iwilltry42
Copy link
Contributor Author

@philippgille sounds good to me - done ✔️

@iwilltry42 iwilltry42 changed the title [DRAFT] add: AzureOpenAI compatibility add: AzureOpenAI compatibility May 13, 2024
@iwilltry42 iwilltry42 marked this pull request as ready for review May 13, 2024 08:02
@philippgille
Copy link
Owner

Thank you for the contribution! 🙇‍♂️

@philippgille philippgille merged commit aa151c6 into philippgille:main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants