Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with empty css selectors #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix issue with empty css selectors #53

wants to merge 3 commits into from
+424 −231

Conversation

timonbandit
Copy link
Contributor

Selector like that

@media (max-width: 575px) {
  .coupon-filter {
  }
}

break crittr. because of error in CSS module.
reworkcss/css#92

@philipp-winterle philipp-winterle self-assigned this May 6, 2024
@philipp-winterle philipp-winterle added the reproducing Issue is not known yet and has to be reproduced to fix label May 6, 2024
@philipp-winterle
Copy link
Owner

Thanks.

should have already happend. Wondering why it hits now.

Can you please add a test for this example to have it covered?

philipp-winterle
philipp-winterle requested changes May 6, 2024
View reviewed changes
Copy link
Owner

@philipp-winterle philipp-winterle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for empty selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-winterle philipp-winterle philipp-winterle requested changes

Assignees

@philipp-winterle philipp-winterle

Labels
reproducing Issue is not known yet and has to be reproduced to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timonbandit @philipp-winterle