Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance ReCodeCruftLeftInMethodsRule #16556

Closed
wants to merge 1 commit into from
Closed

Enhance ReCodeCruftLeftInMethodsRule #16556

wants to merge 1 commit into from

Conversation

AngelHely
Copy link
Contributor

This pull request proposes an improvement for the rule ReCodeCruftLeftInMethodsRule to take pragmas #haltOrBreakpointForTesting or #debuggerCompleteToSender into account. #14250

@MarcusDenker
Copy link
Member

The Pr looks strange, it removes the PharoCommonTools class?

MetacelloNotification: Loaded -> Tool-Base --- tonel:///builds/workspace/est_and_branch_Pipeline_PR-16556/64/src()
SystemNotification: Starting postload action
UndeclaredVariableRead: Attempt to read undeclared variable PharoCommonTools
UndeclaredVariable>>runtimeUndeclaredReadInContext:

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Apr 30, 2024
@AngelHely
Enhance ReCodeCruftLeftInMethodsRule
8876692 
this pull request propose an improvement for the rule ReCodeCruftLeftInMethodsRule to take pragmas #haltOrBreakpointForTesting or #debuggerCompleteToSender into account. #14250
@jecisc jecisc removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label May 13, 2024
@jecisc jecisc closed this May 13, 2024
@jecisc jecisc reopened this May 13, 2024
@AngelHely AngelHely closed this by deleting the head repository May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AngelHely @MarcusDenker @jecisc