Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a simple MoveTo taskbar menu item #16544

Open
wants to merge 1 commit into
base: Pharo13
Choose a base branch
from

Conversation

macta
Copy link
Contributor

@macta macta commented Apr 28, 2024

Adds a simple MoveTo menu item for taskbar items (useful to move something like the Transcript or Repository window to the front of the Taskbar)

@macta
Copy link
Contributor Author

macta commented Apr 28, 2024

I meant to add this to Pharo12 but didn't get to it in time (and I know many people hate the taskbar and lots of windows - but I'm ok with them, and just like to have a few of them at the front and then I clean up the other windows at the end of the list)

@Ducasse
Copy link
Member

Ducasse commented Apr 28, 2024

Hi tim

Thanks. I think that in the future we should a pre-release announce :).
BTW I do not really get what is your feature, even reading the code :).

S

@macta
Copy link
Contributor Author

macta commented Apr 28, 2024

Just to make it more obvious (as per @Ducasse feedback) - its adds a 3rd option to the move tab menu
image

And then lets you pick an absolute location:
image

Entering 1 will put the selected task item at the beginning on the list.

@Ducasse
Copy link
Member

Ducasse commented Apr 28, 2024

Ah ok yes now I understand.

taskBarSize := self worldTaskbar orderedTasks size.
taskLocation := self worldTaskbar orderedTasks indexOf: self taskbarTask.

answer := UIManager default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that Stephane wants us to reduce the references to UIManager. But Spec is loaded after SystemWindow so I am not so sure of how to do what you are doing without UIManager. Maybe @Ducasse or @estebanlm know?

Copy link
Contributor Author

@macta macta May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a simple way to ask for input - so presumably there is a recommended way to do this going forward and I can adjust and resubmit.

Worth adding, I've tried to use the taskbar primitives already there to keep the api as small as possible in case there are changes proposed in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The window tabs taskbar doesn't have a "Move To" option (only left/right)
4 participants