Reflectivity fixing bytecode to ast mapping #16489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecisc
added
the
Status: Need more work
|
This PR has one failing test: osx-64 / Tests-osx-64 / testLinkCountTwoLinks – MacOSX64.Reflectivity.Tests.ReflectiveMethodTest |
|
The tests are still buiding using Pharo12 somehow |
|
I'm running the tests again, as I plan to work on it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug in syntax highlighting in the debugger because there is a desync between methods on the stack and methods modified with breakpoints in the system.
With @MarcusDenker
Step 1
[x] Moving the metalink count from the reflective method to the method node (as a property)
[ ] Ensure that every compiled method has its own reflective method
Step 2
[ ] Move the bytecode-ast mapping to the method node
[ ] Move the dedicated bytecode-mappings of blocks to a dictionary in their parent method node bytecode-mappings