P11 - During compilation there are redundant allocation of collections #16485
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tesonep
commented
Apr 19, 2024
tesonep
commented
- Provide an implementation of #next:putAll:startingAt: for AbstractBinaryStream
- Improve the implementation of #duplicateTerminatorMarkOn: to avoid the creation of the stream, and the copies if not needed.
- Provide an implementation of #next:putAll:startingAt: for AbstractBinaryStream - Improve the implementation of #duplicateTerminatorMarkOn: to avoid the creation of the stream, and the copies if not needed.
tesonep
changed the title
|
@tesonep Hey Pablo, the equivalent was merged in P12. Should we still backport to P11 or close this PR? |
|
I think that if there is no harm, we should integrate. The work is done, there is value in it. Worse case we can always revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.