tests for rules from the General-Rules package #16474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2024 09:37
|
This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title. |
this commit propose 5 tests for rules from Genral-Rules-Tests : ReClassNotCategorizedRule, ReClassVariableCapitalizationRule, ReEquivalentSuperClassMethodsRule, ReExcessiveInheritanceRule, RelongMethodsRuleTest
jecisc
added
Status: Need more work
jecisc
requested changes
Apr 18, 2024
src/General-Rules-Tests/ReInconsistentMethodClassificationRuleTest.class.st
Outdated
Show resolved
Hide resolved
src/General-Rules-Tests/ReInconsistentMethodClassificationRuleTest.class.st
Outdated
Show resolved
Hide resolved
src/General-Rules-Tests/ReEquivalentSuperclassMethodsRuleTest.class.st
Outdated
Show resolved
Hide resolved
the test for the class ReAsRule is not good, so we delete this test for the moment.
add tests in case there is no violation + improve tests in class ReEquivalentSuperclassMethodsRuleTest + ReInconsistentMethodClassificationRuleTest
jecisc
reviewed
Apr 25, 2024
src/General-Rules-Tests/ReInconsistentMethodClassificationRuleTest.class.st
Outdated
Show resolved
Hide resolved
jecisc
reviewed
Apr 25, 2024
src/General-Rules-Tests/ReInconsistentMethodClassificationRuleTest.class.st
Outdated
Show resolved
Hide resolved
…Test.class.st Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
…Test.class.st Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
jecisc
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request propose tests for rules from the General-Rules package with the tag migrated