Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16436-Using-shortcut-CmdCtrl-W-on-a-window-with-multiple-tabs-closes-the-entire-window-instead-of-focused-tab #16468

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Apr 16, 2024

Fix #16436

  • Adding a closeByShortcut so windows can react different
  • Renaming closeTopWindow to closeTopWindowByShortcut
  • Adding an entry point so submorphs can collaborate with the window
  • ClyGroupWindowMorph can handle the event and remove one of the panes

- Adding a closeByShortcut so windows can react different
- Renaming closeTopWindow to closeTopWindowByShortcut
- Adding an entry point so submorphs can collaborate with the window
- ClyGroupWindowMorph can handle the event and remove one of the panes
@jecisc
Copy link
Member

jecisc commented Apr 16, 2024

I have a problem with the generated image.

If I have a message browser with 3 tabs. I do CMD + w and it closes the active tab. Then I do it again. I was expecting the second tab to close because it should be the active one. Instead it did nothing.

@estebanlm estebanlm changed the base branch from Pharo12 to Pharo13 April 26, 2024 09:09
@guillep
Copy link
Member

guillep commented May 21, 2024

Hi @tesonep !

This was fixed here already before the release
#16493

I think we can close this one, if needed, please tell we will reopen it.

@guillep guillep closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using shortcut Cmd/Ctrl-W on a window with multiple tabs closes the entire window instead of focused tab
4 participants