New driver for the push up method refactoring #16438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This showed a 6X speed-up on a MacBookPro 2018
…on semaphore for the cache instead of one per font.
…: and #reportCacheState on FreeTypeCache wait for the semaphore.
…ype: on FreeTypeCache.
…eeTypeCache remove emptied dictionaries from the ‘fontTable’ (so that fonts for which there are no more entries also get removed).
…her than all of them.
this commit propose 5 tests for rules from Genral-Rules-Tests : ReClassNotCategorizedRule, ReClassVariableCapitalizationRule, ReEquivalentSuperClassMethodsRule, ReExcessiveInheritanceRule, RelongMethodsRuleTest
the test for the class ReAsRule is not good, so we delete this test for the moment.
add tests in case there is no violation + improve tests in class ReEquivalentSuperclassMethodsRuleTest + ReInconsistentMethodClassificationRuleTest
…er’ Form in #initialize for MenuItemMorph by the drawing of the corresponding polygon.
… and ‘UpArrow’ in MenuItemMorph, which held a Form, by corresponding variables that hold a FormSet.
this pull request propose 5 tests for rules of the package General-Rules
this pull request propose a rule to validate that users do not use initialize but setUp. pharo-project#5792
ReSetUpRule become a subclass of ReNodeReWriteRule
This change is a new step at reducing the references to SystemAnnouncer class>>#uniqueInstance references in order to remove the singleton in the future.
…tCase-classlastRunMethodNamed Cleanup: TestCase class>>#lastRunMethodNamed:
…tCase-classhasErrorTest Cleanup: TestCase class>>#hasErrorTest, TestCase class>>#hasPassedTest and TestCase class>>#hasFailedTest
Changed 'Transcript show:' construct to 'self trace'
…eddedCachedInfoFor:index:"
…/preconditions-return-array-by-default Refactor: preconditions return array of preconditions by default
This fixes testCodeCruftLeftInMethods that is currently failing and also improves the CI logs to list the methods that should fail the rules we are testing but that do not make it fail. This alongside with the Roassal update should get us a green CI.
…rph-submenumarker-formset Make ToggleMenuItemMorph use a FormSet for the submenu marker
…tialize add rule to avoid that TestCase rely on Initialize
…eftInMethods Fix testCodeCruftLeftInMethods
Update roassal to v1.06d
…teRefactoryChangedefineClass-arguments-seems-incorrectly-named Fix `RBCompositeRefactoryChange>>#defineClass:` argument name
This PR removes the package Calypso-SystemPlugins-ClassScripts-Queries-Tests because it did not contains any tests but only examples. One of the two example class is useless and got removed. I moved the only example class remaining in Calypso-SystemPlugins-ClassScripts-Queries and I gave it a more explicit name to make sure developers understand it is examples.
- Returned Date should have same offset as receiver, but currently has local offset. - Includes test that was failing, but now passes.
Simplify Calypso packaging
…ex: and FreeTypeFontFileUpdator >> failedToOpen:from:index: + use #whileTrue instead of #whileTrue:
proposition refactoring -> Cleanup: 2 duplicated methods in FreeType
…s-respect-offset [Bug]: Date>>#addMonths: should Respect Offset
this pull request propose a potential rule that check methods have not nil branch useless. pharo-project#16515
tests for rules from the General-Rules package
proposition rule for nil branch
…inds of breaking changes
|
Replaced by PR#16637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements driver for handling the user interaction logic when applying the push up method refactoring.
Tests are created for the new ReConditions