Updating vm version on the cmake #700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jordanmontt But we should update the image together with the VM. |
|
Done! The CI is still failing however :/ |
guillep
reviewed
Oct 6, 2023
cmake/vmmaker.cmake
Outdated
| URL https://files.pharo.org/image/110/Pharo11-SNAPSHOT.build.688.sha.cf3d3fd.arch.64bit.zip | ||
| URL_HASH SHA256=c050ddcedce70ec92c22a3244aa5ebbc655dcaffcb42ac80fbf1f6e795c7010d | ||
| URL https://files.pharo.org/image/110/Pharo11-SNAPSHOT.build.707.sha.f720787.arch.64bit.zip | ||
| URL_HASH SHA256=b96a943513c6a79c7319b285e46719fbe74c570ace3fa0c9ead43123c165671a | ||
| BUILD_COMMAND ${VMMAKER_VM} --headless ${VMMAKER_DIR}/image/Pharo11-SNAPSHOT-64bit-cf3d3fd.image --no-default-preferences save VMMaker |
There was a problem hiding this comment.
Now it is failing because the hash in this line is not right and it does not find the image :)
There was a problem hiding this comment.
I re-ran sha256sum Pharo11-SNAPSHOT.build.707.sha.f720787.arch.64bit.zip and it gives me that hash that is committed. And the image Pharo11-SNAPSHOT.build.707.sha.f720787.arch.64bit.zip is the last one built on files.pharo.org
There was a problem hiding this comment.
I know, I selected the line below ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the vm version of the
vmmaker.cmakefile. I took the latest releases of https://files.pharo.org/vm.I did not update the vm of
pharo-spur64-headless/Linux-aarch64andpharo-spur32-headless/Linux-armv7lbecause there was not new versions released for those OSs.One thing, I didn't change the hash, which I suppose that also changed. Where are the hashes available? I didn't find them