Execute quick primitives using primitive table entries in StackVM #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 19, 2023 15:19
Update primitive execution method for Stack vm. Add basic tests
…into a C constant: #(#primitivePushTrue #primitivePushFalse #primitivePushNil #primitivePushMinusOne #primitivePushZero #primitivePushOne #primitivePushTwo)
Update method with correct answer for primitive function pointers
Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the primitive table to enable quick primitive methods to be executed in the Stack VM conforming to the standard execution of primitives, and replacing the need to use executeQuickPrimitive method testing for multiple primitive numbers. So it makes the logic more consistent with primitive execution.
Add a basic set of tests which verifies the state of the execution stack before and after the usage of quick primitives.