Many gcs #653
Open
Many gcs #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guille Polito <guillermopolito@gmail.com> Co-authored-by: Nahuel Palumbo <nahuel.palumbo@gmail.com>
# Conflicts: # smalltalksrc/VMMaker/SpurMemoryManager.class.st # smalltalksrc/VMMaker/StackInterpreterPrimitives.class.st # src/parameters/parameters.c
guillep
reviewed
Jul 19, 2023
| HYBRID_COMPACTOR = 1, | ||
| SWEEP_COMPACTOR = 2, | ||
| SELECTIVE_COMPACTOR = 3 | ||
| } GarbageCollector; |
There was a problem hiding this comment.
Ok so here we have some indices,
| newWithExpression: (TVariableNode named: variableToTest) | ||
| selectors: (possibleClasses collect: [ :class | | ||
| class staticallyResolvePolymorphicSelector: aSendNode selector ]) | ||
| arguments: aSendNode arguments |
|
|
||
| self staticallyResolvedPolymorphicReceivers | ||
| at: polymorphicVariable | ||
| put: { typeVariable } , classes |
There was a problem hiding this comment.
Maybe in a following iteration, we should have something better than an array here?
| @@ -31,7 +31,7 @@ Class { | |||
| 'VMBasicConstants', | |||
| 'VMSpurObjectRepresentationConstants' | |||
| ], | |||
| #category : #'VMMaker-SpurMemoryManager' | |||
| #category : #'VMMaker-InterpreterSimulation' | |||
| [:selectorToStaticallyResolve| | ||
| aCCodeGenerator | ||
| staticallyResolveMethodNamed: selectorToStaticallyResolve | ||
| forClass: self | ||
| to: (self staticallyResolvePolymorphicSelector: selectorToStaticallyResolve)]]] | ||
| to: (self staticallyResolvePolymorphicSelector: selectorToStaticallyResolve)]] |
Comment on lines
+6804
to
+6810
|
|
||
| " gcType caseOf: { | ||
| [ 0 ] -> [ planningCompactor postSwizzleAction ]. | ||
| [ 1 ] -> [ sweepCompactor postSwizzleAction ]. | ||
| ONLY SELECTIVE | ||
| }. | ||
| " |
There was a problem hiding this comment.
Suggested change
| " gcType caseOf: { | |
| [ 0 ] -> [ planningCompactor postSwizzleAction ]. | |
| [ 1 ] -> [ sweepCompactor postSwizzleAction ]. | |
| ONLY SELECTIVE | |
| }. | |
| " | |
| compactor postSwizzleAction. |
?
| from: ObjStackFreex | ||
| to: ObjStackNextx + (self rawHashBitsOf: stackOrNil). | ||
| to: ObjStackNextx + (self rawHashBitsOf: stackOrNil) ]. | ||
| }. |
There was a problem hiding this comment.
Ok, this one needs polymorphism :)
There was a problem hiding this comment.
Ah, actually not, if we are here we know the compactor is always a planning compactor. Maybe we need to move this method to the compactor
| from: ObjStackFreex | ||
| to: ObjStackFreex. | ||
| to: ObjStackFreex ]. | ||
| }. |
| @@ -69,6 +70,7 @@ EXPORT(int) vm_init(VMParameters* parameters) | |||
| setMaxOldSpaceSize(parameters->maxOldSpaceSize); | |||
| setDesiredEdenBytes(parameters->edenSize); | |||
| setMinimalPermSpaceSize(parameters->minPermSpaceSize); | |||
| setGarbageCollectorType(parameters->garbageCollector); | |||
There was a problem hiding this comment.
Suggested change
| setGarbageCollectorType(parameters->garbageCollector); | |
| setGarbageCollectorType(parameters->garbageCollector); |
| parameters->garbageCollector = PLANNING_COMPACTOR; | ||
|
|
||
| return VM_SUCCESS; | ||
| } |
There was a problem hiding this comment.
All the changes in this file are hidden in the re-formatting. Even hiding white spaces in the PR shows a lot of noise... It would have been nice to not have it...
(There is still a problem to transform different methods with the same selector)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in DojoVM - Douai edition (and more)!
Merged changes in #649 (I cannot point to it because it comes from a fork, even though we work in the same team 😞)
So, this PR includes: