Refactoring the primitive at:
#638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalumboN
reviewed
Jul 4, 2023
Comment on lines
+15998
to
+16015
| { #category : #'indexing primitive support' } | ||
| StackInterpreter >> validateArray: array andIndex: index [ | ||
| "This is a helper method to valide if the array and the index parameter are valid. | ||
| For example, that the index is an integer, that the array is not a forwarder, etc." | ||
|
|
||
| <inline: true> | ||
| "Validate that the receiver is not immediate" | ||
| (objectMemory isImmediate: array) | ||
| ifTrue: [ ^ self primitiveFailFor: PrimErrInappropriate ]. | ||
|
|
||
| "If the index is not an integer, fail" | ||
| "If the array is a forwarder, for example in the case of e.g. object:basicAt:, fail" | ||
| (objectMemory isNonIntegerObject: index) | ||
| ifTrue: [ ^ self primitiveFailFor: PrimErrBadArgument ]. | ||
| (objectMemory isForwarded: array) | ||
| ifTrue: [ ^ self primitiveFailFor: PrimErrBadArgument ] | ||
| ] | ||
|
|
There was a problem hiding this comment.
Take care
- You cannot move these validations outside the main method, because the returns were prepared to cut the flow. If you want to do this you have to check
self successfulafter this method is called. - I think that validation is missing also:
argumentCount > 1 "e.g. object:basicAt:"
| StackInterpreter >> commonAt: stringy [ | ||
| StackInterpreter >> commonAt [ |
There was a problem hiding this comment.
I suggest not changing this method. We know that works and manage all the cases.
Just create the specialised versions and this one will be dead eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-doing PR: #633
Summary:
Actually, there was already the primitive primitiveStringAt that was calling the method commonAt: with the flag set to true. So there is no need to add a new primitive and this is not a breaking change for Pharo.
Missing things: