Frame unification #602
Open
Frame unification #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73c5165.
Now instVarAt: can be called both from within and outside the interpreter
privat
reviewed
Jul 3, 2023
| 'jitCodeZoneWriteEnabled' | ||
| 'jitCodeZoneWriteEnabled', | ||
| 'cePrimReturnEnterCogCode', | ||
| 'cePrimReturnEnterCogCodeProfiling' |
There was a problem hiding this comment.
why those two ivars were moved around?
|
|
||
| "In cog the base frames are married, in non cog they are not" | ||
| self isCog ifTrue: [ | ||
| theContext := self ensureFrameIsMarried: theFP SP: (self frameReceiverLocation: theFP). |
There was a problem hiding this comment.
isCog here feels inconsistent with the rest of the PR
What about a method that returns nil in the StackInterpretor and possibly perform matrimonial work in the CoInterpretor?
moreover, the method moveFramesIn... is very similar that the one overridden in CoInterpretor, so I'm not even sure that the isCog is meaningful in neither. Could it be possible to have a single method moveFramesIn... for both?
There was a problem hiding this comment.
Yes, I refactored so they look very similar (and the repetition could eventually be removed). But at some point I put my time on fixing issue and making the PR pass ^^
guillep
commented
Jul 4, 2023
privat
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight differences in the shape of frames between the pure interpreter and the VM with JIT make a lot of code duplication and make it difficult to change and debug.
This PR unifies both. The main idea that the JIT VM keeps the same frame organisation, it is the non-JIT VM (used to debug mainly nowadays) that accommodates slightly.
The core differences dealt with are:
Other minor details include the refactoring in the management of instruction pointers which in the JITt'ed VM can have a mixture of machine code and interpreter instruction pointers. The code should do the same but just avoid repetition.
Also, several minor cleanups of dead code observed on the way