remove inline from worker_dispatch_callout #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok with this change, but I'd like a second pair of eyes. @tesonep @estebanlm do you remember why there is an |
|
I don't remember :/ |
hogoww
added a commit
to hogoww/opensmalltalk-vm
that referenced
this pull request
Dec 23, 2021
… [ allocateOldSpaceChunkOfBytes: ]
hogoww
added a commit
to hogoww/opensmalltalk-vm
that referenced
this pull request
Dec 23, 2021
…[ allocateOldSpaceChunkOfBytes: ] KILLED by 1/168 test cases.
hogoww
added a commit
to hogoww/opensmalltalk-vm
that referenced
this pull request
Dec 29, 2021
… [ objectBytesForSlots: ]
hogoww
added a commit
to hogoww/opensmalltalk-vm
that referenced
this pull request
Dec 29, 2021
…[ objectBytesForSlots: ] KILLED by 1/47 test cases.
|
Any news on this one? We are building the VM using Windows MSVC compiler. For this, we need to to address the |
syrel
added a commit
to feenkcom/gtoolkit-vm
that referenced
this pull request
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a funny one.
worker.c >> worker_dispatch_callout()is marked asinlineand is called fromworkerPrimitives.c. However, Clang is smart enough to not createworker_dispatch_calloutfunction at all, it literaly inlines it. However, it turns out thatworker_dispatch_calloutis called from the other object file which results in the linker error: