apparently, nobody ever registered the repository to be finalized pro…

…perly
pharo-nosql · Sep 5, 2023 · f84e6e5 · f84e6e5
1 parent a679bd0
commit f84e6e5
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 3 deletions.
diff --git a/mc/Voyage-Model-Core.package/VOExternalRepository.class/instance/initialize.st b/mc/Voyage-Model-Core.package/VOExternalRepository.class/instance/initialize.st
@@ -1,4 +1,5 @@
 initialization
 initialize 
+
 	super initialize.
-	self initializeCache.
+	self initializeCache
diff --git a/mc/Voyage-Model-Core.package/VOExternalRepository.class/instance/initializeCache.st b/mc/Voyage-Model-Core.package/VOExternalRepository.class/instance/initializeCache.st
@@ -1,3 +1,4 @@
 initialization
 initializeCache
+
 	cache := VOCache new.
diff --git a/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/class/defaultPoolSize.st b/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/class/defaultPoolSize.st
@@ -1,3 +1,4 @@
 defaults
 defaultPoolSize
-	^ 10
+
+	^ 1
diff --git a/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/instance/finalize.st b/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/instance/finalize.st
@@ -1,3 +1,4 @@
 finalization
 finalize
+
 	self stopSDAMClient
diff --git a/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/instance/initialize.st b/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/instance/initialize.st
@@ -1,6 +1,11 @@
 initialization
 initialize
+
 	super initialize.
+
+	"register for finalization"
+	FinalizationRegistry default add: self.
+
 	insertConcerns := SmallDictionary new.
 	removeConcerns := SmallDictionary new.
 	updateConcerns := SmallDictionary new.
diff --git a/...ckage/VOMongoRepository.class/instance/initializeMongoUrls.database.username.password..st b/...ckage/VOMongoRepository.class/instance/initializeMongoUrls.database.username.password..st
@@ -1,8 +1,10 @@
 initialization
 initializeMongoUrls: aCollection database: databaseString username: aUserName password: aPassword
+
 	databaseName := databaseString.
 	username := aUserName.
 	password := aPassword.
+
 	self initialize.
 
 	self ensuringCurrentOnSave: false.
@@ -15,4 +17,4 @@ initializeMongoUrls: aCollection database: databaseString username: aUserName pa
 		maxConnections: self poolSize;
 		connectTimeout: self connectionTimeout;
 		socketTimeout: self connectionTimeout.
-	sdamClient start.
+	sdamClient start
diff --git a/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/instance/stopSDAMClient.st b/mc/Voyage-Mongo-Core.package/VOMongoRepository.class/instance/stopSDAMClient.st
@@ -1,3 +1,4 @@
 finalization
 stopSDAMClient
+
 	sdamClient ifNotNil: #stop