Minor refactoring on existing SCRAMSHA1AuthMechanism #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common logic is moved to a new parent class SCRAMSHAAuthMechanism. Descendant classes SCRAMSHA1AuthMechanism and SCRAMSHA256AuthMechanism only customize the hash function to use. This PR doesn't implement the handshake mentioned in pharo-nosql#87.
rydnr
changed the title
|
Thanks for the contribution. |
|
The CI errors in Pharo 9 are unrelated to this change, and same tests run successfully in Pharo 8. |
tinchodias
reviewed
Jan 12, 2021
Comment on lines
+2
to
+3
| authenticateAgainstAdmin | ||
| overrideDB := true |
There was a problem hiding this comment.
Now, I realize this method has no senders and uses a variable that is not defined.
I will remove it.
@rydnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactoring on existing SCRAMSHA1AuthMechanism. Common logic is moved to a new parent class SCRAMSHAAuthMechanism. Descendant classes SCRAMSHA1AuthMechanism and SCRAMSHA256AuthMechanism only customize the hash function to use.
This PR doesn't implement the handshake mentioned in #87.