Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #425

Merged
merged 1 commit into from Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Expand Up @@ -152,7 +152,7 @@ That means strings like `v1.2.0` or `1.2` will turn into `1.2.0`.
Please note: Version 0.13.x is the last to support PHP 7.1. Users are encouraged to upgrade to PHP 7.2 or later.

### Fixed
* Github blocks HEAD requests to their API Rate Limit endpoint, use GET
* GitHub blocks HEAD requests to their API Rate Limit endpoint, use GET


## [0.13.4] - 2020-09-18
Expand Down Expand Up @@ -222,7 +222,7 @@ Please note: Version 0.13.x is the last to support PHP 7.1. Uses are encouraged
### Changed

* Added `keys.openpgp.org` to keyserver list
* Changed order of keyservers: new verifing keyserver first, use fedora & ubuntu second, sks as last resort
* Changed order of keyservers: new verifying keyserver first, use fedora & ubuntu second, sks as last resort
(This will be less of an issue once [#158](https://github.com/phar-io/phive/issues/158) is implemented.)

## [0.12.2] - 2019-06-02
Expand Down
6 changes: 3 additions & 3 deletions src/commands/outdated/OutdatedCommand.php
Expand Up @@ -171,8 +171,8 @@ private function renderXmlOutput(array $outdated): string {
}

private function writeToFile(string $output): void {
$destionation = $this->outdatedConfig->outputFilename();
$destionation->getDirectory()->ensureExists();
file_put_contents($destionation->asString(), $output . "\n");
$destination = $this->outdatedConfig->outputFilename();
$destination->getDirectory()->ensureExists();
file_put_contents($destination->asString(), $output . "\n");
}
}
4 changes: 2 additions & 2 deletions src/services/resolver/GithubAliasResolver.php
Expand Up @@ -50,7 +50,7 @@ public function resolve(RequestedPhar $requestedPhar): SourceRepository {
return $this->tryNext($requestedPhar);
} catch (GithubAliasResolverException $e) {
$this->output->writeWarning(
sprintf('Github API Rate Limit exceeded - cannot resolve "%s"', $name)
sprintf('GitHub API Rate Limit exceeded - cannot resolve "%s"', $name)
);

return $this->tryNext($requestedPhar);
Expand Down Expand Up @@ -87,7 +87,7 @@ private function ensureWithinRateLimit(): void {
$this->initRateLimit();

if ($this->rateLimit->getRemaining() === 0) {
throw new GithubAliasResolverException('Github API over rate limit');
throw new GithubAliasResolverException('GitHub API over rate limit');
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/shared/environment/Environment.php
Expand Up @@ -153,7 +153,7 @@ private function disableXDebug(): void {
ini_set('xdebug.max_nesting_level', '8192');
ini_set('xdebug.show_exception_trace', 'off');

// since `xdebug_disable` got removed in Xdebug 3 we have to check for its existance
// since `xdebug_disable` got removed in Xdebug 3 we have to check for its existence
if (function_exists('xdebug_disable')) {
xdebug_disable();
}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/repository/GithubRepository.php
Expand Up @@ -71,7 +71,7 @@ public function getReleasesByRequestedPhar(RequestedPhar $requestedPhar): Releas
}

$releases->add(
// Github doesn't publish any hashes for the files :-(
// GitHub doesn't publish any hashes for the files :-(
new SupportedRelease($name, $version, $pharUrl, $signatureUrl)
);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/regression/PurgeCommandTest.php
Expand Up @@ -11,7 +11,7 @@
namespace PharIo\Phive\RegressionTests;

class PurgeCommandTest extends RegressionTestCase {
public function testDeletesPurgablePhar(): void {
public function testDeletesPurgeablePhar(): void {
$this->addPharToRegistry('phpunit', '5.3.4', 'phpunit-5.3.4.phar');

$this->assertTrue(
Expand Down
Expand Up @@ -53,7 +53,7 @@ public function testNotInErrorWithMissingNew(): void {
/**
* No phive.xml, and no global.xml.
*/
public function testNotInErrorWithBothOldANdNewMissing(): void {
public function testNotInErrorWithBothOldAndNewMissing(): void {
$migration = $this->createMigration([]);

$this->assertFalse($migration->inError());
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/shared/UrlTest.php
Expand Up @@ -116,7 +116,7 @@ public function testReturnsRootPathForUrlsWithoutPath(): void {
$this->assertEquals('/', (new Url('https://host'))->getPath());
}

public function testFilenameCanBeRetreived(): void {
public function testFilenameCanBeRetrieved(): void {
$this->assertEquals(
new Filename('some.phar'),
(new Url('https://example.com/some.phar'))->getFilename()
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/shared/http/CurlHttpClientTest.php
Expand Up @@ -124,7 +124,7 @@ public function testThrowsHttpExceptionIfHttpCodeIs0(): void {
$this->curlHttpClient->get($url);
}

public function testHandleProgressInfoPassesEpectedObjectToProgressHandler(): void {
public function testHandleProgressInfoPassesExpectedObjectToProgressHandler(): void {
$this->curl->method('getHttpCode')
->willReturn(200);

Expand Down