WIP: Pg16 tests #340
Merged
WIP: Pg16 tests #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note other changes needed to be made for this:
- Add new postgres16, it's misnamed as moment, cause it doesn't have
postgis yet
- Change postgresql_postgis.sh to:
- Use trusted instead of apt-key which is deprecated
- Added a condition to postgresql_postgis.sh to skip PostGIS
install if no PostGIS version is specified
Since PostGIS is not yet available in
apt.postgresql.org repo for PG16
- Use pgdg-snapshot instead of main
repo except for PG12
(it has all stable branches and main)
- For PG12, jsut continue to use main repo,
since PostGIS 2.5 is not carried in snapshot
robe2
force-pushed
the
pg16-tests
branch
3 times, most recently
from
6ecc3e6
to
692e3a3
Compare
|
Hello @robe2, Thanks a lot for this PR 👍. Considering that this PR fixes #338 and also add PG16 tests, I propose to:
What do you think? |
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pg16 does not yet have PostGIS, but tests pass.
So I'm labeling this a WIP since I will change to install PostGIS once PostGIS is available in apt.postgresql.org