Fix resolving PGMODELER_ROOT from pgmodeler.vars #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pgmodeler.vars is source'd the $0 variable expands to '-bash' which causes readlink to fail and PGMODELER_ROOT being set to the wrong directory. This is fixed by using a while loop that recursively changes directory following symlinks along the way util it reaches the end and then reads the current working directory. For more info, see: https://gist.github.com/TheMengzor/968e5ea87e99d9c41782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pgmodeler.vars is source'd the
$0variable expands to '-bash'which causes
readlinkto fail andPGMODELER_ROOTbeing set to the wrongdirectory.
This is fixed by using a while loop that recursively changes directory
following symlinks along the way util it reaches the end and then reads
the current working directory.
For more info, see:
https://gist.github.com/TheMengzor/968e5ea87e99d9c41782