WIP: rework TypeInfoCache #3062
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to use the recent pg_type fields (e.g. typarray to detect arrays), and ::regclass to parse type names
davecramer
reviewed
Dec 7, 2023
| @@ -2275,7 +2275,8 @@ protected void processResults(ResultHandler handler, int flags, boolean adaptive | |||
| // Handle status. | |||
| String status = receiveCommandStatus(); | |||
| if (isFlushCacheOnDeallocate() | |||
| && (status.startsWith("DEALLOCATE ALL") || status.startsWith("DISCARD ALL"))) { | |||
| && (status.startsWith("DEALLOCATE ALL") || status.startsWith("DISCARD ALL") | |||
| || status.startsWith("CREATE ") || status.endsWith("DROP "))) { | |||
| deallocateEpoch++; | |||
There was a problem hiding this comment.
Shouldn't this be status.startsWith("DROP ") ?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to use the recent
pg_typefields (e.g.typarrayto detect arrays), and::regclassto parse type names.The previous code had several drawbacks:
Mapfor navigating between oids, names, and other information. It is hard to maintain, and it is hard to invalidate the caches.= ANY(current_schemas(..)) order by oid limit 1might produce wrong oids.The PR uses
where oid = ?::regtypeapproach to lookup types with the full support of identifier quoting.We do not need that many cache maps, so the invalidation with the new approach would be easier.
This is an early draft, and it might make sense to make
PgTypeinto different subclasses. For instance, there might bePgArrayType extends PgType, andPgArray { PgArrayType getType(); }.TODO:
schema_pathchanges, create, drop statementsint4PgTypeto a top-level, and add subtypes (e.g.PgArrayTypefor use inPgArray)