Add values in ignore_startup_parameters #1048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently you can only define the key of a parameter in the ignore_startup_parameters section. With this change you can define a key=value string in that section. For example you can set the following: [pgbouncer] ignore_startup_parameters = options,extra_float_digits=2 If an application attempts to connect using as startup parameter the extra_float_digits=3, then pgBouncer will produce an error. This is useful to avoid hidden bugs when using this section between application logic changes. Also it can function for clients as indicatory of the expected startup parameters. Signed-off-by: Marjus Cako <marios.cako@hpe.com>
|
Thank you for the contribution this sounds like a useful feature indeed. I haven't looked closely at the code yet. But some initial feedback:
|
|
@marjus45 are you still planning to update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can only define the key of a parameter in the
ignore_startup_parameterssection. With this change you can define akey=valuestring in that section. For example you can set the following:If an application attempts to connect using as startup parameter the extra_float_digits=3, then pgBouncer will produce an error.
This is useful to avoid hidden bugs when using this section between application logic changes. Also it can function for clients as an indication of the expected startup parameters.