Added support for executing query at cursor position. #6841 #7380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed the code and the documentation is not updated as the execute query button icon need to be changed so the images need to be updated accordingly. |
adityatoshniwal
requested changes
May 20, 2024
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSet.jsx
Outdated
Show resolved
Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx
Outdated
Show resolved
Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx
Outdated
Show resolved
Hide resolved
adityatoshniwal
requested changes
May 22, 2024
There was a problem hiding this comment.
- remove padding
- I cannot select and copy the SQL from SQL Popup.
- Preferences real-time is not fixed.
- Console error is not fixed. Getting the same error.
- Warning dialog sometimes is not showing even if enabled.
- The editor size issue of dialog is not fixed.
- These preferences should be move to Options, not Editor:
web/pgadmin/tools/sqleditor/static/js/components/dialogs/ConfirmPromotionContent.jsx
Outdated
Show resolved
Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx
Outdated
Show resolved
Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/ResultSetToolbar.jsx
Outdated
Show resolved
Hide resolved
| @@ -388,6 +396,12 @@ export function MainToolBar({containerRef, onFilterClick, onManageMacros}) { | |||
| });} | |||
| } | |||
| }, | |||
| { | |||
| shortcut: queryToolPref.execute_script, | |||
There was a problem hiding this comment.
Are we migrating the old shorcut preference set by the user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.