Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #2582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CONTRIBUTING.md #2582

wants to merge 1 commit into from

Conversation

benleamon
Copy link

#2581 .

Changes proposed in this pull request:

  • Adds information relating to contributions on behalf of employers, code coming from sources other than the contributor, and preserving copyright and attribution information for code coming from other projects.

@pgRouting/admins

@cvvergara cvvergara marked this pull request as draft November 3, 2023 14:57
@cvvergara
Copy link
Member

Some suggestions that generated this PR

  • Add information about contributions developed on behalf of an employer.
  • Add information about contributions coming either from the contributor or another valid source (e.g. the public domain or a project with a compatible license).
  • I noticed that before committing people are supposed to "Fill in the commit message template." I wasn't able to find this template, but it could be good to link to it in contributing.md
  • Ben also noticed that there is another contributing.md file in .github.
  • Should release processes and guidelines also be included here?
  • OSGeo also recommends including expectations for committers

@benleamon benleamon marked this pull request as ready for review November 11, 2023 09:09
robe2
robe2 requested changes Nov 25, 2023
View reviewed changes
Copy link
Member

@robe2 robe2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license is spelled wrong in these changes. Should be license not liscence

robe2
robe2 requested changes Feb 6, 2024
View reviewed changes
CONTRIBUTING.md
@@ -41,6 +41,12 @@ Any kind of contribution will automatically fall to the following Licences:
* Documentation contribution:
* Creative Commons Attribution-Share Alike 3.0

Contributions developed for an employer or as part of a work project also fall under the above liscences. This should be cleared with an authorized supervisor or manager in advance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change liscenses -> licenses

CONTRIBUTING.md
@@ -41,6 +41,12 @@ Any kind of contribution will automatically fall to the following Licences:
* Documentation contribution:
* Creative Commons Attribution-Share Alike 3.0

Contributions developed for an employer or as part of a work project also fall under the above liscences. This should be cleared with an authorized supervisor or manager in advance.

Contributions should be developed by the contributor, from the public domain, or from an open source project under a compatible liscence. If the code does not come from the contributor, the original source should be clearly marked.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change liscense -> license

CONTRIBUTING.md

Contributions should be developed by the contributor, from the public domain, or from an open source project under a compatible liscence. If the code does not come from the contributor, the original source should be clearly marked.

Do not remove existing copyright headers and liscence text from contributions. If the copyright holder wants to give up copyright, they must do so in writing before any copyright messages are deleted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change liscense -> license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robe2 robe2 robe2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benleamon @cvvergara @robe2