Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Fix "Not a gitflow-enabled repo" bug https://github.com/petervanderdo… #374

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

silasfn
Copy link
Contributor

@silasfn silasfn commented Jun 17, 2018

…es/gitflow-avh/issues/372

Fix "Not a gitflow-enabled repo" bug - issue reported at #372

Fix "Not a gitflow-enabled repo" bug - issue reported at petervanderdoes#372
@nmcc
Copy link

nmcc commented Jun 19, 2018

I've applied this fix locally on my box and it solved the issues for git flow feature commands.
But the git flow release commands are still failing with the same message

@silasfn
Copy link
Contributor Author

silasfn commented Jun 21, 2018

Johannes made a good suggestion over here:
git-for-windows/git#1720
I've applied the suggested change to the PR as it seems to work on my local for the following

git flow feature start [feature name]
git flow feature finish [feature name]
git flow release start [release name]
git flow release finish [release name]

@nmcc and others - does the pushed change work for you?

@nmcc
Copy link

nmcc commented Jun 22, 2018

With this latest fix, all commands are working on my Windows box that had the error.
I'll test on the other box that was not raising the error just to be sure. I'll provide feedback soon.

@petervanderdoes
Copy link
Owner

Anybody testing this please show me the output of git config --get-regexp gitflow.prefix

The point of this command is to check if keys starting with gitflow.prefix exists in the git config. By adding the ! (=not), you are saying that it's a Gitflow enabled repo when these prefixes don't exists, and if they do it's not a Gitflow enabled repo. I have no access to a Microsoft 10 license so I can start up a VM with Windows 10.

@silasfn
Copy link
Contributor Author

silasfn commented Jun 24, 2018

$ git config --get-regexp gitflow.prefix
gitflow.prefix.feature feature/
gitflow.prefix.bugfix bugfix/
gitflow.prefix.release release/
gitflow.prefix.hotfix hotfix/
gitflow.prefix.support support/
gitflow.prefix.versiontag

@dscho
Copy link

dscho commented Jun 25, 2018

@petervanderdoes oh! You're here! I got the impression that this gitflow-avh was abandoned. It's good that I was wrong!

@petervanderdoes
Copy link
Owner

I've been AWOL for a while, my apologies.

@dscho
Copy link

dscho commented Jun 25, 2018

I've been AWOL for a while, my apologies.

No worries. It is great to have you back!

@silasfn
Copy link
Contributor Author

silasfn commented Jun 28, 2018

Welcome back Peter. I'm pretty new to the community, but it sounds like you were greatly missed.
So ... any thoughts on the pull request? Is that good to merge? I've been using it for a while now on my Windows 10 box with no issues.

@dscho
Copy link

dscho commented Oct 13, 2019

Maybe a ping would be in order? @petervanderdoes ping?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants