Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nsi-installer.patch #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

james2432
Copy link

Adding patch file to nsi installer for relative path correction

Related to #1

Adding patch file to nsi installer for relative path correction
Apply nsi patch

Related to petersasi#1
Adding python call to generate file list required by NSI to generate the installer/uninstaller
Script to generate the install/uninstall file list needed by nsis
update patch file
@mhertz
Copy link
Contributor

mhertz commented Sep 22, 2020

@petersasi

Not important, but imho good idea to ditch the nsis folder under C:\deluge2 and instead move the needed files from it(LICENSE, deluge.ico and nsis-installer script) into installer-build, and then change the nsis script as per the first commit in this PR, plus change the build-script(s, as you concatenated them into one, I see) for new path. Just little cleaner, and one less redundant folder. I quickly did it on my end and tested, which worked fine - i'm sure you don't need instructions for that, but otherwise let me know, of-course.

@james2432

You've been busy :) Nice that you tested, reported and contributed, thanks, though not my scripts anymore, but nonetheless :) Many of the issues you had, is because there's a few files missing on this repo, which i'm sure Peter will get to later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants