Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added center of mass to Panda DH definition (and cleaned it up a bit) #304

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jenskober
Copy link

In pull request #294 some of the inertia parameters were ported from the matlab version. The center of mass for the links was still missing (without which dynamics calculations will be wrong). I've added them here and also cleaned up the white space a bit.

Copy link

@AunSiro AunSiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to suggest the same thing. However, it must be noted that the parameters come from https://github.com/marcocognetti/FrankaEmikaPandaDynModel which uses the axes as in https://frankaemika.github.io/docs/control_parameters.html, but the model here ignores the (7) axes and links the last solid to the (F) axes. Therefore, the center of mass of the last solid must be given in (F) coordinates.

roboticstoolbox/models/DH/Panda.py Outdated Show resolved Hide resolved
Co-authored-by: Anonymous Researcher <siro.moreno.martin@gmail.com>
@jenskober
Copy link
Author

jenskober commented Jul 12, 2022

@AunSiro Thanks! Indeed, both the marcocognetti and frankaemika DH definition include a static 8th joint for the flange, while here this is rolled into the 7th joint, so the center of mass needs to be updated.
The robotics-toolbox uses inertia around center of mass, so indeed only the center of mass changes.

@jenskober
Copy link
Author

should now be compatible with the latest version in master

@JeanElsner
Copy link

I too was about to suggest the same thing, before I saw your pull request. It would be great to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants