fix(ktx): allow only 1 observer to receive the event (#681)

* fix: allow only 1 observer to receive the event * fix: remove observer * fix: observe LD when permission is not granted
permissions-dispatcher · Aug 30, 2020 · 9901c95 · 9901c95
1 parent 0f90714
commit 9901c95
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/ktx/src/main/java/permissions/dispatcher/ktx/PermissionsRequesterImpl.kt b/ktx/src/main/java/permissions/dispatcher/ktx/PermissionsRequesterImpl.kt
@@ -10,23 +10,19 @@ internal class PermissionsRequesterImpl(
     private val onShowRationale: ShowRationaleFun?,
     private val onPermissionDenied: Fun?,
     private val requiresPermission: Fun,
-    onNeverAskAgain: Fun?,
+    private val onNeverAskAgain: Fun?,
     private val permissionRequestType: PermissionRequestType
 ) : PermissionsRequester {
-    init {
-        val viewModel = ViewModelProvider(activity).get(PermissionRequestViewModel::class.java)
-        viewModel.observe(
-            activity,
-            requiresPermission,
-            onPermissionDenied,
-            onNeverAskAgain
-        )
-    }
-
     override fun launch() {
         if (permissionRequestType.checkPermissions(activity, permissions)) {
             requiresPermission()
         } else {
+            ViewModelProvider(activity).get(PermissionRequestViewModel::class.java).observe(
+                activity,
+                requiresPermission,
+                onPermissionDenied,
+                onNeverAskAgain
+            )
             val requestFun = {
                 activity.supportFragmentManager
                     .beginTransaction()