Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Main sample which would not compile #8283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajrao
Copy link

@rajrao rajrao commented Apr 27, 2022

The code would through an error of: Line 105, Column 14: Expression "r" is not an rvalue. Fixed and tested as working

The code would through an error of: Line 105, Column 14: Expression "r" is not an rvalue. Fixed and tested as working
@buildguy

This comment has been minimized.

@hitachivantarasonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ddiroma
Copy link
Contributor

ddiroma commented Apr 29, 2022

@rajrao Is there a BACKLOG or PDI case associated with this change?

@rajrao
Copy link
Author

rajrao commented Apr 29, 2022

Hi Dean, I dont think so. I found this issue while I was working with Spoon. Let me know if I should create an issue and associate it with it.

@ddiroma
Copy link
Contributor

ddiroma commented Apr 29, 2022

Sure, there are many small issues that you will come across in Spoon, but any code change will require an appropriate bug/story that will require QA testing. Please log a bug with more context (PDI version, repro steps, testing requirements, etc.). Feel free to assign it to your team and inform your PO and ScrumMaster. Thanks.

@rajrao
Copy link
Author

rajrao commented Apr 29, 2022

Please see: https://jira.pentaho.com/browse/PDI-19509. Also, regarding: "Feel free to assign it to your team and inform your PO and ScrumMaster", I dont work on a Pentaho team. Submitted this patch as a user of Spoon

@buildguy

This comment has been minimized.

@smaring smaring requested a review from a team as a code owner October 17, 2023 15:28
@buildguy
Copy link
Collaborator

buildguy commented Mar 4, 2024

❌ Build failed in 2m 10s

Build command:

mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox

❗ No tests found!

ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants