feat: DraggablePoint in solids
#1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
Deploying penrose with
|
| Latest commit: |
b10c79e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aee0f703.penrose-72l.pages.dev |
| Branch Preview URL: | https://drag.penrose-72l.pages.dev |
samestep
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #issue.
This PR adds a
DraggablePointcomponent to@penrose/solids, which is inspired by Movable points in Mafs.Implementation strategy and design decisions
DraggablePoint.tsxand use it ineigenvalues.tsxrosenow that it's introduced by refactor: integrate Rose #1636.Checklist
Examples and how to reproduce them
Run
nx run solids:devto see the eigenvalue example. All draggable points use `DraggablePoint".Open questions
DraggablePointwill need a ref to the outer SVG to compute the right transforms. I think usually people use contexts to pass these things around.transformis technically not needed ifxandyare in the SVG screen space. It's only needed becauseDraggablePointupdatesxandyafter dragging. Should we expose them as callbacks instead?