Allow logging to process #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a different process could create the lock between both calls to open(2) with the result that two processes access the same serial port. Fix this by specifying only opening the lock file with O_CREAT | O_EXCL. Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
While at it remove the now outdated comment about kermit compatibility. It no longer applies to ckermit [1]. [1]: pengutronix#9 (comment) Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
If microcom crashes, e.g. due to the buffer underflow described in pengutronix#10, it may leave a stale lock file behind. Teach microcom detection of these stale lock files. Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
In preparation for piping the log into a file, mark existing file descriptors so they are closed for exec'ing child processes. Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
While microcom's stdout can be piped to another processes, it makes input somewhat of a hassle. Address this by teaching the --logfile option and the log command that a filename starting with a pipe character refers to an executable to start and pipe the input into. The child process shares stderr, but has stdout closed. Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
|
I am not sure whether a |
|
commit "Set O_CLOEXEC on newly opened file descriptors" looks fine. Didn't look in detail at the second patch yet. But as there are some changes requested in #9 I won't merge as is anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is rebased on top of #9 to avoid the merge conflict. I'll rebase when the other one is merged.