Changed API from bot-centered to method-centered #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Moved execute method from TelegramBot to BaseRequest • Moved DeleteMyCommands.java from model to request • Added BaseRequest.api member for execute method • Added api argument to all constructors and static generator functions and passed them down to BaseRequest. • Added wrapper functions for all requests in TelegramBot. • Fixed tests to use new API. NOTE: LogOutCloseTest.java is inherently broken and has to be fixed. • Deprecated the entire SetStickerSetThumb class, instead of one of the compilers. • Fixed API usage in sample to match the new API. • Added lambda syntax to execute method
|
@pengrad review? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #164