updates to register_objects to allow relabelling #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluethi
reviewed
Apr 15, 2020
There was a problem hiding this comment.
It's not something I'd generally encourage people to do, as it could lead to many issues if relabeling is performed before registration. This may fuse many existing objects, especially for secondary segmentations and thus be very confusing to users.
If we can add some sort of warning / indication that this is an advanced feature and not an option to play around with, then that's ok
| @@ -1,4 +1,4 @@ | |||
| # Copyright (C) 2016 University of Zurich. | |||
| # Copyright 2016 Markus D. Herrmann, University of Zurich | |||
There was a problem hiding this comment.
Don't see a reason to Markus back in now that you're changing the module
| type: Boolean | ||
| value: false | ||
| help: > | ||
| Should objects be relabeled on registration. |
There was a problem hiding this comment.
Can we add a warning here that this shouldn't normally be done? Some users just seem to try out options at this is definitely an advanced feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases it is useful, but I can't exactly remember when...anyway the default is
False