Updated some german abbreviations & added support for fractional housenumbers #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH mess up fix
Not very common in germany, but some counties decided that this would be a good idea.
|
hi @arnesetzer there is an issue running CI for external contributors. Please rebase master against your branch and push to trigger the CI |
Joxit
requested changes
Jun 21, 2022
|
@arnesetzer the unit tests are failing, you can run them locally with the command |
Joxit
requested changes
Aug 17, 2022
| @@ -15,7 +15,8 @@ class HouseNumberClassifier extends WordClassifier { | |||
| /^(\d{1,5})[a-zA-Z\u0400-\u04FF]?\/(\d{1,5})$/.test(span.body) || // 1/135 or 1b/135 Style | |||
| /^(\d{1,5})([nsewNSEW])(\d{1,5})[a-zA-Z]?$/.test(span.body) || // 6N23 Style (ie Kane County, IL) | |||
| /^([nsewNSEW])(\d{1,5})([nsewNSEW]\d{1,5})?$/.test(span.body) // W350N5337 or N453 Style (ie Waukesha County, WI) | |||
There was a problem hiding this comment.
Missing || at the end of the line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 馃殌
Here's what actually got changed 馃憦
Examples:
Here's how others can test the changes 馃憖
Import the german osm data and try to find these buildings by their address. As far as I concerned these are written down correctly in OSM