Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nokia SR OS support (draft) #639

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jbemmel
Copy link

@jbemmel jbemmel commented Oct 17, 2022

This is a tentative PR to add support for Nokia SR OS through an additional NAPALM driver

It is not intended to be merged just yet - the referenced napalm-sros version 1.0.1 isn't available yet - but this is just to give the project a heads up on what we are planning to contribute, and to have a chance to receive any feedback/comments/concerns

  • Add "Nokia SR OS" platform choice
  • Add napalm-sros and bcrypt as dependencies
  • Add Nokia Bcrypt password encoding

@jbemmel jbemmel marked this pull request as draft October 17, 2022 16:15
@wtremmel
Copy link
Contributor

It would be great if you added some template examples as well...

@jbemmel
Copy link
Author

jbemmel commented Oct 17, 2022

Am still working on the device configuration templates, but I did have a sample virtual lab that may be of interest

@jbemmel jbemmel force-pushed the add-nokia-sros-support branch 8 times, most recently from 15697b1 to ce2cca1 Compare November 1, 2022 04:32
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@amulheirn
Copy link

Hi - just discovered this. I'd very much like to see this feature - see my discussion here: #727

@samuk10
Copy link

samuk10 commented Oct 18, 2023

i coudnt manage to make netsim to work. not related to this project PR.

@rinsekloek
Copy link
Contributor

rinsekloek commented Oct 21, 2023

If somebody has interest, I have installed the Napalm SROS driver added Nokia SROS with NAPALM drive sros.
At this moment I can make config diffs and commits. Only issue is that Error reporting if config is not correct, Is not handled as expected. I will dig into this.

At this moment I have a pretty decent template with policy-options / prefix-list / bgp peers /groups/ and communities. Will share this one if its throughly tested.

@jbemmel I had created a small change to the driver, because it always detected merge differences: matching (ex)[]
Tested on TiMOS-C-23.3.R3 cpm/x86_64 Nokia 7750 SR Copyright (c) 2000-2023 Nokia running an Containerlab.

line 403 of /usr/local/lib/python3.9/dist-packages/napalm_sros/sros.py 
 elif re.search(r'\(ex\)\[\/?\]', item):
in stead of 
 elif "(ex)[]" in item:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants