-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-411 - Service References Unique Constraints #428
Draft
jamesditrapani
wants to merge
11
commits into
peering-manager:main
Choose a base branch
from
jamesditrapani:PM-411-service-ref
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PM-411 - Service References Unique Constraints #428
jamesditrapani
wants to merge
11
commits into
peering-manager:main
from
jamesditrapani:PM-411-service-ref
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge bugfixes from Main
gmazoyer
reviewed
May 23, 2021
Moved to backlog, will be addressed in the future. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
Keeping open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Closes #411
Stop
service_reference
being generated as a UUID. Convert to a Unique ID based on the Database ID of a newServiceReference
model.To fix:
Unique constraints on
service_reference
do not carry over between Direct & IX Peering Sessions.