Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getProfilePicUrl #2365

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix: getProfilePicUrl #2365

wants to merge 17 commits into from

Conversation

imaperson1060
Copy link

@imaperson1060 imaperson1060 commented Jul 28, 2023 •
edited by alechkos

PR Details

Description

  • Added Chat.getProfilePicUrl method
  • Added support for channels and communities

Motivation and Context

I did this because I noticed that there wasn't a method to get the group's icon, and when I tested it, it worked.

How Has This Been Tested

I tested all the methods I changed/added. The new ones work the same as Contact.getProfilePicUrl() and the ones that I changed are all behind the scenes, so there are no breaking changes.

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

Santosl2
Santosl2 reviewed Jul 28, 2023
View reviewed changes
Copy link

@Santosl2 Santosl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shirser121
Copy link
Collaborator

Where do we standing with this?

Santosl2
Santosl2 reviewed Aug 7, 2023
View reviewed changes
src/Client.js Show resolved Hide resolved
@alechkos alechkos changed the title Get group's icon URL fix: getProfilePicUrl Dec 8, 2023
@alechkos alechkos enabled auto-merge (squash) December 13, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santosl2 Santosl2 Santosl2 approved these changes

@FabricioHein FabricioHein FabricioHein approved these changes

@alechkos alechkos alechkos approved these changes

@shirser121 shirser121 Awaiting requested review from shirser121

@aliyss aliyss Awaiting requested review from aliyss

@tuyuribr tuyuribr Awaiting requested review from tuyuribr

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@imaperson1060 @shirser121 @FabricioHein @Santosl2 @alechkos