Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/pipe: update pipe file compression example #708

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

command/pipe: update pipe file compression example #708

wants to merge 2 commits into from

Conversation

ahmethakanbesel
Copy link
Contributor

@ahmethakanbesel ahmethakanbesel commented Mar 3, 2024 •
edited

Closes #704

Replaced

tar -cf - file.bin | s5cmd pipe s3://bucket/file.bin.tar

with

gzip -c file | s5cmd pipe s3://bucket/file.gz

Why?

  • Less flags, less confusing
  • To be consistent with the other examples

@ahmethakanbesel ahmethakanbesel marked this pull request as ready for review March 3, 2024 08:52
@ahmethakanbesel ahmethakanbesel requested a review from a team as a code owner March 3, 2024 08:52
@ahmethakanbesel ahmethakanbesel requested review from ilkinulas and seruman and removed request for a team March 3, 2024 08:52
@ahmethakanbesel ahmethakanbesel changed the title readme: update pipe file compression example command/pipe: update pipe file compression example Mar 3, 2024
kucukaslan
kucukaslan approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@kucukaslan kucukaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor igungor approved these changes

@kucukaslan kucukaslan kucukaslan approved these changes

@ilkinulas ilkinulas Awaiting requested review from ilkinulas ilkinulas is a code owner automatically assigned from peak/big-data

@seruman seruman Awaiting requested review from seruman seruman is a code owner automatically assigned from peak/big-data

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README.md incorrect example "you can compress the data before uploading"
3 participants
@ahmethakanbesel @igungor @kucukaslan