Bump go module version to v2 #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmanley
requested review from
aykutfarsak and
ilkinulas
and removed request for
a team
|
Any chance this is going to be approved/merged? |
|
@justinmanley could you rebase your branch please? |
justinmanley
force-pushed
the
fix-go-mod-for-v2
branch
from
a1f1ed9
to
e610d6b
Compare
|
@igungor rebased! |
igungor
approved these changes
Jun 19, 2023
|
@justinmanley thank you! |
|
hi @ilkinulas! could you take a quick look at this when you get a chance? |
ilkinulas
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go modules with version >= 2.0.0 must have module names ending with
/v2(or, for versionN,/vN).Without this, running
go get github.com/peak/s5cmd@v2.0.0results in the following error:This requirement is explained in greater detail in the official golang wiki.