Introduce a flag to preserve timestamps of files #534
+287
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--preserve-timestamp` flag will set metadata on the s3 objects and then update the files on disk during a download. If the `--preserve-timestamp` flag is passed during an upload the following metadata keys will be set: - x-amz-meta-file-ctime - x-amz-meta-file-mtime - x-amz-meta-file-atime If the `--preserve-timesamp` flag is passed during a download, s5cmd will attempt to modify the created files on disk. **There doesn't appear to be a way to change the created date on Linux
Ahuge
requested review from
igungor and
seruman
and removed request for
a team
|
I'd love to see this merged - @Ahuge could you rebase it and maybe ping a maintainer to try again for a review? |
|
Hi @Ahuge, thanks for the PR. With the addition of #621 and the request #350, I think these two could be handled in a similar fashion as s5cmd specific file metadata. I have a PoC which is not ready for a review yet. I would like to get your thoughts on it once it is ready. I kindly request for you to wait for it to get your thoughts if it would cover yours and @strophy's use cases. |
|
Hi @seruman just checking on progress and if there is anything I can do to help move this issue along? Having this feature would allow us to switch back to s5cmd from aws-cli, with big performance benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to issue #532
We are implementing a flag that when activated will record and store ctime, mtime, and atime in S3 as metadata on the object.
When pulling files down, if that data exists, we will set it on the files as well.
Linux & Darwin don't appear to allow setting of ctime, however atime and mtime are preserved.
Windows does allow us to set ctime, mtime, and atime, however they are actually referred to as CreationTime, LastAccessTime, and LastWriteTime.
Please let me know if you have feedback on this PR.
Thanks!