Fix activate for windows and updated docs for Azure #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…thub.com/pluttodk/pdm into fix-activate-for-windows-and-update-docs
frostming
reviewed
Apr 26, 2024
| @@ -55,6 +56,8 @@ def get_activate_command(self, venv: VirtualEnv) -> str: # pragma: no cover | |||
| command, filename = "source", "activate" | |||
| activate_script = venv.interpreter.with_name(filename) | |||
| if activate_script.exists(): | |||
| if platform.system() == "Windows": | |||
| return f"{shlex.quote(str(activate_script))}" | |||
There was a problem hiding this comment.
look above several lines, we have a case for powershell. this will completely bypass it.
There was a problem hiding this comment.
This only works for powershell 7 and not 5.1. Neither does the old solution work for Batch.
I did not want to remove the previous check with powershell, since you can install powershell on linux (not sure why you would want that but you can) and that supports the dot command.
Output from powershell 5.1
> Invoke-Expression (pdm venv activate)
C:\Code\data_indhentning\.venv\Scripts\Activate.ps1 : Cannot dot-source this command because it was defined in a differ
ent language mode. To invoke this command without importing its contents, omit the '.' operator.
At line:1 char:1
+ . 'C:\Code\.venv\Scripts\Activate.ps1'
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : InvalidOperation: (:) [Activate.ps1], NotSupportedException
+ FullyQualifiedErrorId : DotSourceNotSupported,Activate.ps1
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
Altered the
pdm venv activateto not include"."on windows, since this causes an error. This also ensures, that for non Powershell users on windows, the outputted command can be directly pasted into shell.Additionally added documentation as to how to add authentication to Azure Artifacts, since this seems to be a common question asked. Such as: #2760