Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dropXFA option for fillForm. Refactoring fillForm options. #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SciencePiggy
Copy link

No description provided.

@johntayl
Copy link
Collaborator

Adding options args seems to be the wanted approach for a while. fillFormWithFlatten() would be redundant if fillFormWithOptions() arguments are going to be modified to support the options arg.

Looking at the pdftk args, this could also be a property within options, instead of written checks for specific edge cases (ie. drop_xfa).

_defaultOptions = {
    args: [], // [ 'flatten', 'drop_xfa', ... ]
    tempFDFPath: undefined
}

@SciencePiggy
Copy link
Author

SciencePiggy commented Mar 30, 2017

Truth be told I wasn't paying close enough attention when I opened my PR. That said ...

I agree RE: fillFormWithFlatten() but I didn't want to rock the boat in terms of deprecating code, which I failed to do with fillFormWithOptions(). Current commit is a half measure but may be the safer approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants