Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show full path name in headerbar (fixes #1085) #1086

Merged
merged 3 commits into from May 11, 2024

Conversation

b-sharman
Copy link
Contributor

@b-sharman b-sharman commented Apr 19, 2024

see #1085

It looks like this for me now:
image
Please let me know if I've missed anything!

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (7643541) to head (af7c153).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   79.67%   79.67%           
=======================================
  Files          13       13           
  Lines        4965     4965           
=======================================
  Hits         3956     3956           
  Misses       1009     1009           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dreua dreua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if Handy makes me wonder in which cases we don't have Handy. Are those substantial enough to reconsider this change? (Probably not, but I really don't know.)

pdfarranger/pdfarranger.py Outdated Show resolved Hide resolved
@b-sharman
Copy link
Contributor Author

In regards to dependence on Handy, I thought it was a little strange to check for it since non-libhandy headerbars have a set_title too. I tried setting Handy=None and removing the check like this:

    def set_title(self, title, subtitle = None):
        self.uiXML.get_object('header_bar').set_title(title)
        self.uiXML.get_object('header_bar').set_subtitle(subtitle)

and it seemed to work fine, although I'm not sure how I would test it more rigorously.

@kbengs
Copy link
Member

kbengs commented Apr 21, 2024

I think it would be fine to remove the if Handy as @b-sharman suggest. But can be done later also.
Seems to work well.

@kbengs kbengs merged commit 14fdb3f into pdfarranger:main May 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants