Add standard paper sizes to "insert blank page" and "page size" dialogs #1066
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
- Coverage 79.66% 79.59% -0.08%
==========================================
Files 13 13
Lines 4963 5076 +113
==========================================
+ Hits 3954 4040 +86
- Misses 1009 1036 +27 ☔ View full report in Codecov by Sentry. |
|
Support for common pape sizes is a great improvment imo, thanks for the initiative!
Haven't tried your branch yet but from reading this sounds not ideal for the user experience. Had to read that twice to even understand it. How hard would it be to change the other value based on the value a user just changed manually? We don't support disproportionate scaling at all, do we? (I mean stretching in one dimension more or less than in the other. It's not what someone wants to do with PDFs I hope 😉 ) |
The old (fit to) "Width" or "Height" are removed as the new "Fit to paper" can handle thouse cases too
kbengs
force-pushed
the
page-format-names3
branch
from
07ab982
to
7b96bc9
Compare
I think that was a good idea so now it look like this:
|
kbengs
force-pushed
the
page-format-names3
branch
from
3140ac2
to
2908129
Compare
|
With "Fit mode" added: |
* Basename is stored only at document level (in PDFDoc class) * Description is stored only at page level (in Page class) * Page separator character in serialized data is changed so that it will not conflict with '/n' used in description (under thumbnail)
Blank pages only make sense as main page
The modes are: 1. Scale page to fit into size 2. Scale page and add white margins to fit the size 3. Crop page (if nessessary) and/or add white margins to fit the size Aspect ratio is always preserved.
kbengs
force-pushed
the
page-format-names3
branch
from
2908129
to
c30c35c
Compare
Old - New
Scaling to a paper size is what I usually want to do. The old (fit to) "width" and "height" can be achieved by setting for example width to desired value and height to a large value.
As the translation files was updated, this can wait to next release if you like to.