Add range selection for pages #1065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added menu item to select
menu and select context menus.
- Added range_select_dialog method
to pdfarranger.py for completing the range selection.
- Handles ranges with '-' or comma separated list
of values
- Handles min/max cases. (-3 ==> 0 to 3,
or 4- ==> 4 to end)
- Dialog has real time check of user input to
limited set of characters ('0123456789,- ') using
on_change signal.
- Labels/titles are translatable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 79.66% 78.69% -0.98%
==========================================
Files 13 13
Lines 4963 5032 +69
==========================================
+ Hits 3954 3960 +6
- Misses 1009 1072 +63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#862 in one commit