refactor: remove ecToken from modalContent request #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surekhaw
approved these changes
May 14, 2024
perco12
approved these changes
May 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2024
### [1.64.3](v1.64.2...v1.64.3) (2024-05-14) ### Bug Fixes * origami styling ([#1080](#1080)) ([28d5fc1](28d5fc1)) ### Code Refactoring * ensure content attribute on meta element is not incorrectly set to undefined after closing modal ([#1083](#1083)) ([905905e](905905e)) * fix donut dash position ([#1089](#1089)) ([b2429be](b2429be)) * pass modal zoid polyfill duration as string ([#1066](#1066)) ([f1b66cd](f1b66cd)) * remove ecToken from modalContent request ([#1091](#1091)) ([0beb8d6](0beb8d6)) * remove extra older zalgo-promise dependency ([#1093](#1093)) ([3733916](3733916)) * update GB legal disclosure content in modals ([#1092](#1092)) ([78e759d](78e759d))
|
🎉 This PR is included in version 1.64.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ec_tokenfrommodalContentrequest to mitigate downstream calculation disparities when entering application flow of Pay Monthly.Screenshots
Testing instructions
ec_tokenis not being sent as a query param as part of themodalContentrequest.ec_tokenshould continue being sent to/credit-presentment/smart/modalendpoint.