feat: dynamic messages - modal instrumentation #2380
Draft
+34
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paypal-rosman
changed the title
Seavenly
reviewed
May 21, 2024
src/zoid/buttons/component.jsx
Outdated
Comment on lines
746
to
754
| const modalInstance = await getModal( | ||
| clientID, | ||
| merchantID, | ||
| buttonSessionID | ||
| ); | ||
| return modalInstance?.show({ | ||
| amount, | ||
| offer: offerType, | ||
| buttonSessionId: buttonSessionID, |
There was a problem hiding this comment.
We should only need to pass the buttonSessionID into either getModal or show. I don't think we need to do both. Since we need it in getModal for the events, we can probably omit it from show since the buttonSessionID value shouldn't change.
There was a problem hiding this comment.
okay i will remove one from the show right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!