update axo loader library #2355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage 58.00% 58.00%
=======================================
Files 153 153
Lines 12232 12232
Branches 742 742
=======================================
Hits 7095 7095
Misses 5041 5041
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ravishekhar
approved these changes
Mar 26, 2024
| @@ -1,5 +1,5 @@ | |||
| /* @flow */ | |||
| import { loadAxo } from "@paypal/connect-loader-component"; | |||
| import { loadAxo } from "@paypal/accelerated-checkout-loader/dist/loader.esm"; | |||
There was a problem hiding this comment.
Can we make the loader a top level export from this package? Bit worried that importing nested dependencies can create issues with future refactorings in this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the revert. This is re-adding the updated axo library