Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for adding properties to callog to track rac timestamp value #391

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rasamala83
Copy link
Collaborator

No description provided.

@rasamala83
Copy link
Collaborator Author

rasamala83 commented Apr 18, 2024

This change adds an extra 80 to 95 bytes for every RAC_ID cal event. This event triggers only in case of any RAC maintenance.

Sample:
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926087&exitInSec=48sec
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926135&exitInSec=96sec
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926183&exitInSec=144sec
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926231&exitInSec=192sec

lib/workerpool.go Outdated Show resolved Hide resolved
@@ -718,7 +718,7 @@ func (pool *WorkerPool) RacMaint(racReq racAct) {
if logger.GetLogger().V(logger.Verbose) {
logger.GetLogger().Log(logger.Verbose, "Rac maint activating, worker", i, pool.workers[i].pid, "exittime=", pool.workers[i].exitTime, now, window, pool.currentSize)
}
cnt++
racMaintWorkers = append(racMaintWorkers, []interface{}{pool.moduleName, pool.ShardID, i, pool.workers[i].exitTime, pool.workers[i].exitTime - now})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Instead of this, can we have an event inside this loop?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated this review comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants